getnikola / nikola-themes

Themes for Nikola
https://themes.getnikola.com/
71 stars 53 forks source link

nikola theme parents step on nikola installed themes #5

Closed yarko closed 11 years ago

yarko commented 11 years ago

when parent "default" (for example) is changed in nikola (such as happened recently, to factor out slides.tmpl), the default (now outdated) theme here becomes inconsistent / incompatible with nikola.

Suggest - either keep the nikola default installed themes here updated / sync'd with nikola, or (better) remove the default nikola thieme components from this repo (you could reference them from one or the other repo too).

ralsina commented 11 years ago

The themes repo is always synced with the latest release.

I suspect I need to start doing something about versioning, though.

yarko commented 11 years ago

well, I found this because I pulled a current nikola-themes, sym-linked the themes to my test blog themes directory, and pulled and installed in my virtualenv a current nikola.

The nikola-themes "default" didn't have slides.tmpl - and the themes masked / blocked the installed "default" theme...

So, I don't know what happened with the "always synced" situation here! ;-)

... but I thought I'd point out what was going on. (for my tests, I changed, and symlinked nikola-themes individually to my test-blog, except for the ones included in the default nikola installation).

ralsina commented 11 years ago

On 19/08/13 17:31, yarko wrote:

well, I found this because I pulled a current nikola-themes, sym-linked the themes to my test blog themes directory, and pulled and installed in my virtualenv a current nikola.

The nikola-themes "default" didn't have slides.tmpl - and the themes masked / blocked the installed "default" theme...

So, I don't know what happened with the "always synced" situation here! ;-)

LIke I said "to the latest release". What you are testing is not a release :-)

yarko commented 11 years ago

Ah! Yes, I see... On Aug 19, 2013 6:36 PM, "Roberto Alsina" notifications@github.com wrote:

On 19/08/13 17:31, yarko wrote:

well, I found this because I pulled a current nikola-themes, sym-linked the themes to my test blog themes directory, and pulled and installed in my virtualenv a current nikola.

The nikola-themes "default" didn't have slides.tmpl - and the themes masked / blocked the installed "default" theme...

So, I don't know what happened with the "always synced" situation here! ;-)

LIke I said "to the latest release". What you are testing is not a release :-)

— Reply to this email directly or view it on GitHubhttps://github.com/ralsina/nikola-themes/issues/5#issuecomment-22912728 .

ralsina commented 11 years ago

The themes repo for v6 doesn't include the default themes anymore.