getnikola / nikola

A static website and blog generator
https://getnikola.com/
MIT License
2.62k stars 450 forks source link

Gallery titles broken (again) #919

Closed rogerbinns closed 10 years ago

rogerbinns commented 11 years ago

Nikola version 6.2.1

See http://www.rogerbinns.com/galleries/2013%20Santa%20Cruz%20Day/ as an example and mouse over images to see unexpected titles

In conf.py I have:

USE_FILENAME_AS_TITLE = True GALLERY_SORT_BY_DATE = False

Directory listing for that gallery:

01_The Boardwalk and beach.JPG 02_First of several old cars.JPG 03.JPG 04.JPG 05.JPG 06.JPG 07.JPG 08.JPG 09.JPG 10_One of several speakers at the Wharf centential event.JPG 11_They weren't paying attention.JPG 12_Prime sunbathing spot.JPG 13.JPG 14_Not many out on the water.JPG 15_View of boardwalk from wharf.JPG 16_Long marine lab lookout back into town.JPG 17_There were some birds.JPG 18_a lot of birds.JPG 19_Far too many.JPG 20_At the beach.JPG 21_Some surfers and those who climbed the barriers.JPG

It used to show whatever was after the number.

Possibly pertinent - I changed things so that my top level galleries directory is now a symlink to a directory in dropbox

Kwpolska commented 11 years ago

The question is, what do you want those tooltips to say?

galleries/2013 Santa Cruz Day/01_The Boardwalk and beach.JPG becoming Galleries/2013 santa cruz day/01 the boardwalk and beach looks sanely.

rogerbinns commented 11 years ago

The number should not be shown - it is purely there for ordering purposes as required by my two conf.py settings. In previous Nikola versions it was not shown.

"Galleries" is unnecessary and confusing.

The album title is noise when looking at the album page.

I would expect it to show only what is after the number, which is the empty string for some of those.

ralsina commented 11 years ago

@rogerbinns

You mean the "Galleries" at the crumb bar. It's not unnecessary, it's the way to go back to your gallery list.

If by "the album name" you mean in the same crumb bar, sorry, that's the convention, the whole path is displayed.

AFAICS currently that page is not showing image titles at all, is USE_FILENAME_AS_TITLE still true?

Kwpolska commented 11 years ago

he means tooltips on hovering images, not the crumb bar.

ralsina commented 11 years ago

@Kwpolska good to know, yes, that's a bug. Easier to figure out when, you know, it's described all in one place ;-)

I'll fix tonight.

rogerbinns commented 11 years ago

Does gallery sorting use exactly the same code (ie order on /galleries/ page)? I see an option GALLERY_SORT_BY_DATE but it isn't clear if USE_FILENAME_AS_TITLE also applies to galleries. Because I moved my gallery folders into dropbox the date from the filesystem is no longer reliable. Using exif data is more reliable but there is still the issue of picking the oldest, newest or average value when there are multiple files in a directory.

ralsina commented 10 years ago

I think this is fixed now and has been for a while. A quick check of a build of the demo site confirms it: http://getnikola.com/galleries/demo/ has the correct tooltips.