search

getnikola / plugins

Extra plugins for Nikola
https://plugins.getnikola.com/
MIT License
56 stars 92 forks source link

Plugins are available with "wrong" names #149

Open ralsina opened 8 years ago

ralsina commented 8 years ago

For example, the local_search plugin is available in the site as localsearch.

So:

nikola plugin -i localsearch

versus:

nikola plugin -r local_search

One or the other needs changing, or we need aliases so things work.

punchagan commented 8 years ago

Just listing down other problematic names:

rest_microdata -- microdata

rest_forms -- forms

local_search -- localsearch

render_mustache -- mustache

render_subindexes -- subindexes

tx3TagCloud -- tx3_tag_cloud

wordpress -- wordpress_compiler

felixfontein commented 8 years ago

Just a remark: since both names of the WordPress compiler appear in the import_wordpress plugin coming with Nikola, a simple rename would be a bad idea as it could break released Nikola versions (if they are used to import a WordPress blog with conversion of posts to HTML enabled). So an alias mechanism might be a good idea.

ralsina commented 7 years ago

@felixfontein I don't understand your comment. The wordpress importer ships with core, so you never install it or remove it.

felixfontein commented 7 years ago

The WordPress importer allows to automatically install the WordPress compiler plugin when asked to do so. If we change the name of the WordPress compiler plugin, existing installations of Nikola won't find the plugin anymore if that functionality of the import_wordpress plugin is used.

ralsina commented 7 years ago

No problem, as long as the name we keep is the one used to install :-)

On Wed, Sep 14, 2016 at 9:07 PM Felix Fontein notifications@github.com wrote:

The WordPress importer allows to automatically install the WordPress compiler plugin when asked to do so. If we change the name of the WordPress compiler plugin, existing installations of Nikola won't find the plugin anymore if that functionality of the import_wordpress plugin is used.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/getnikola/plugins/issues/149#issuecomment-247194336, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAGK4d0Lw9R06C3MIJYrZdbTXrxY8QXks5qqIxPgaJpZM4Itob- .

felixfontein commented 7 years ago

Well, that's part of the problem: the import plugin uses both names: one (wordpress) to find the plugin (to determine if it is installed, and to use it when it is installed), and one (wordpress_compiler) to install it (doing so automatically if requested, or by printing the command to install it).