search

getnikola / plugins

Extra plugins for Nikola
https://plugins.getnikola.com/
MIT License
59 stars 95 forks source link

[publication_list] Plugin needs to be adjusted to current Nikola master #180

Closed felixfontein closed 8 years ago

felixfontein commented 8 years ago

The combination of this plugin and getnikola/nikola#2532 breaks the tests: https://travis-ci.org/getnikola/plugins/jobs/167842014

xuhdev commented 8 years ago

I don't understand, why would getnikola/nikola#2532 break dependency tests? They seem totally irrelevant...

xuhdev commented 8 years ago

Removing the line self.deps = 'tests/data/publication_list/test.bib' in the test file "fixes" the test, but there might be something wrong...

Kwpolska commented 8 years ago

There is, the test doesn’t really test it. I’m working on it.

felixfontein commented 8 years ago

The test uses the ReST compiler, which now bails out if it doesn't gets a Post object passed. Before getnikola/nikola#2532, it would try to find out the post object by itself.

@Kwpolska: how about adjusting the ReST compiler such that the compile_html method tries to find the Post object by itself (as it did before)? This should reduce breakages like this one.

Kwpolska commented 8 years ago

That still won’t cut it:

<div class="system-message">
<p class="system-message-title">System Message: ERROR/3 (<tt class="docutils">&lt;string&gt;</tt>, line 1)</p>
<p>Unknown directive type &quot;publication_list&quot;.</p>
<pre class="literal-block">
.. publication_list:: tests/data/publication_list/test.bib
        :highlight_author: Nikola Tesla
</pre>
</div>
 3 DependencyList(None, [])
Kwpolska commented 8 years ago

Wait, I’m missing dependencies locally. It’s a one-line fix then.

Kwpolska commented 8 years ago

@Kwpolska: how about adjusting the ReST compiler such that the compile_html method tries to find the Post object by itself (as it did before)? This should reduce breakages like this one.

I had to patch test_rst_compiler.py to make that finding work.

felixfontein commented 8 years ago

Ok. Main thing is that it's fixed now :)