getnikola / plugins

Extra plugins for Nikola
https://plugins.getnikola.com/
MIT License
59 stars 95 forks source link

[similarity] Ignore scheduled posts and convert to LateTask #384

Closed JesperDramsch closed 3 years ago

JesperDramsch commented 3 years ago

First of all, apologies for the messy PR. Most changes were due to black formatting. I didn't see any guidelines on linter or a contributor manifest but wanted to make sure it's PEP8 compliant.

Main changes:

JesperDramsch commented 3 years ago

@Kwpolska hey, here's the PR. The checks failing seems outside of my control for now, but happy to work on it when the checks don't error out during setup.

Kwpolska commented 3 years ago

Thanks for fixing this!

First of all, apologies for the messy PR. Most changes were due to black formatting. I didn't see any guidelines on linter or a contributor manifest but wanted to make sure it's PEP8 compliant.

FYI, we use flake8 for our linter, balck is sometimes not compatible with flake8 — I fixed one such thing. Quite frankly, black did a terrible job at formatting this file, mainly due to the line length limit — we’re more liberal than that, and in my experience, black becomes readable past 100 and even better around 120 characters per line.

JesperDramsch commented 3 years ago

Ah that's fair. Thanks for the fix!