search

getnikola / plugins

Extra plugins for Nikola
https://plugins.getnikola.com/
MIT License
56 stars 92 forks source link

Support http(s) URLs for postcast enclosure #414

Closed anderbubble closed 1 year ago

anderbubble commented 2 years ago

I decided to move my podcast episodes out of my nikola site source tree and into an object store. This change supports building a postcast from enclosures that are at an explicit full URL.

anderbubble commented 2 years ago

This change also adds a dependency on the requests library, to get the size of the file. Let me know if I need to do anything to document that dependency.

anderbubble commented 2 years ago

Fixed a linter error.

anderbubble commented 2 years ago

When I ported in upstream changes to my local install, explicit calls to category langs was breaking the plugin. I think my change at https://github.com/getnikola/plugins/pull/414/files#diff-7889d47a9a3d5d5c88ee3016dfe350e36cc274a366c77066f8057986a967540aL71-L72 fixes it, but I've never been 100% confident in my understanding of nikola i18n.

anderbubble commented 2 years ago

It looks like the remaining failing checks aren't in my code. Let me know if there's anything else I need to address.

Kwpolska commented 2 years ago

@anderbubble Can you merge/rebase master from the main repo into your branch?

anderbubble commented 2 years ago

@Kwpolska done. Let me know if you need anything else.

I've got another tiny change to PR separately, but I'll file that after this is merged.

anderbubble commented 1 year ago

@Kwpolska checking in to see if there's anything else you need to allow this to be merged.

anderbubble commented 1 year ago

Thank you!