Closed CarstenGrohmann closed 1 week ago
Easy workaround for this,
mv plugins/commonmark/commonmark.py plugins/commonmark/commonmark_plugin.py
and edit plugins/commonmark/commonmark.plugin
:
diff --git a/plugins/commonmark/commonmark.plugin b/plugins/commonmark/commonmark.plugin
index 84e28cb..810ca29 100644
--- a/plugins/commonmark/commonmark.plugin
+++ b/plugins/commonmark/commonmark.plugin
@@ -1,6 +1,6 @@
[Core]
Name = commonmark
-Module = commonmark
+Module = commonmark_plugin
[Nikola]
PluginCategory = PageCompiler
That's a good idea. Let's ask @Kwpolska if he would accept a simple PR with this workaround or if he would like to change the search path handling in the newly introduced plugin manager.
I think changing the plugin names would be a better fix, as it would be more in line with how Python imports work. We’re happy to accept a PR.
@asmeurer: It's your change - would you create a PR for it?
I'll see what I can do later but if you already know where to make the change at you should just do it. I'd need to figure out where this code is even located.
ok, I'll provide a PR.
Hi,
After updating my Nikola installation to v8.3.0 the locally installed commonmark plugin fails.
I can well imagine that with the new Plugin Manager the search path of the modules has changed and the plugin imports itself.
https://github.com/getnikola/plugins/blob/126d38c6e850589d8812f7c5c45121c65ef047b1/v8/commonmark/commonmark.py#L34-L37
This would explain the difference between the following tests with
import commonmark
&&commonmark.Parser
, if the command is executed once in the plugin directory and once outside.What do you think about this issue?
Regards, Carsten