search

getnikola / plugins

Extra plugins for Nikola
https://plugins.getnikola.com/
MIT License
56 stars 92 forks source link

add a github_widget shortcode #439

Closed dacog closed 2 months ago

dacog commented 2 months ago

Hi,

I created a shortcode to show information for a GitHub repository and I thought it would be interesting for others as well, so here it is.

Please let me know if I have to change anything.

Best regards,

Diego

Kwpolska commented 2 months ago

This looks great, just one thing missing (from the README):

Please make sure your plugin has a valid open-source license, and that it has a license comment. For short licenses (MIT/BSD), include the entire license text; for longer licenses (Apache, GPL/LGPL), use the short declarations (Apache, GPL). If you don’t know which license to use, we recommend MIT (as seen in Nikola core).

Please also fix the linting errors:

v8/github_widget/github_widget.py:2:1: F401 'nikola.utils.LOGGER' imported but unused
v8/github_widget/github_widget.py:64:9: F841 local variable 'latest_release' is assigned to but never used
v8/github_widget/github_widget.py:65:9: F841 local variable 'latest_commit' is assigned to but never used
dacog commented 2 months ago

Hi @Kwpolska

Thank you for your feedback. I thought I had read everything. I just added the License (MIT).

I also updated a part of the code to re-enable the last commit and last release args in the shortcode. It seems I had forgotten to push that part before.

The linting should also be fixed.

Would there still be anything missing?

Thanks!

Diego

Kwpolska commented 2 months ago

Thanks for your contribution!