Issue 373 Temporal filters after upgrading to v2.0 - Githubissues

getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨

https://docs.opendatakit.org/aggregate-intro/

Other

74 stars 227 forks source link

Issue 373 Temporal filters after upgrading to v2.0 #374

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

Closes #373

What has been done to verify that this works as intended?

Manually tested following the instructions on #373.

Why is this the best possible solution? Were any other approaches considered?

This PR improves the detection of temporal fields of forms uploaded before upgrading to v2.0

They can lack their FormElementModel
They can be metadata fields
They can have a FormElementModel without child elements

Are there any risks to merging this code? If so, what are they?

Nope.

Do we need any specific form for testing your changes? If so, please attach one

Yes. The instructions to reproduce the scenario are attached to #373

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

Nope.