Issue 370 fix date format on dialogs - Githubissues

getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨

https://docs.opendatakit.org/aggregate-intro/

Other

74 stars 227 forks source link

Issue 370 fix date format on dialogs #376

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

Closes #370

What has been done to verify that this works as intended?

Manually checked correct date formats on the purge dialogs (submissions and publishers)
Manually checked correct dateTime formats on the export and publisher tables

Why is this the best possible solution? Were any other approaches considered?

The best solution would be that GWT emulates java.time and we can reuse JRTemporal on the client but, unfortunately, it doesn't.

I've reproduced the same formats on a new GwtShims class, which is reused across the web UI.

Are there any risks to merging this code? If so, what are they?

Nope.

Do we need any specific form for testing your changes? If so, please attach one

Nope.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

Yes, along with other changes in v2.0