Issue 379 Fix bug in fixOffset method - Githubissues

getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨

https://docs.opendatakit.org/aggregate-intro/

Other

74 stars 227 forks source link

Issue 379 Fix bug in fixOffset method #381

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

Closes #379

What has been done to verify that this works as intended?

Pushed a form with the -fsb flag to enforce parsing the blank form again
Added new unit tests to verify the change and prevent regression

Why is this the best possible solution? Were any other approaches considered?

This is a small change to consider another case where incoming datetime's offset data string should be fixed to a standard iso8601 format.

Are there any risks to merging this code? If so, what are they?

Nope.

Do we need any specific form for testing your changes? If so, please attach one

No.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

No.

kkrawczyk123 commented 5 years ago

Tested with success!

@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"