search

getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨
https://docs.opendatakit.org/aggregate-intro/
Other
74 stars 227 forks source link

Issue 380 Fix geopoint formatting when it lacks alt or acc components #382

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

Closes #380

What has been done to verify that this works as intended?

Added new test cases to verify that we can format geopoints that lack altutide or accuracy components

Why is this the best possible solution? Were any other approaches considered?

This is the smallest change I could come up that takes into account that a geopoint value, and its lat, lon, alt, and acc can be null.

Are there any risks to merging this code? If so, what are they?

Nope.

Do we need any specific form for testing your changes? If so, please attach one

No. Any form with geopoints will do.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

No.

kkrawczyk123 commented 5 years ago

Tested with success! Export to csv confirmed as well.

@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"