search

getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨
https://docs.opendatakit.org/aggregate-intro/
Other
74 stars 227 forks source link

Fix sed error that breaks installs #406

Closed yanokwa closed 5 years ago

yanokwa commented 5 years ago

What has been done to verify that this works as intended?

Confirmed this works with clean install on DO. Also confirmed HTTPS certs are installed.

Why is this the best possible solution? Were any other approaches considered?

Narrowest fix possible.

Are there any risks to merging this code? If so, what are they?

Yes. I am still getting infinite redirects even after using aggregate-cli to install a custom war. Not sure where the problem is, but my recommendation is that we get as close to a stock install as possible. So I'd recommend...

  1. Merge this change.
  2. Publish master as a temporary v2.0.0 pre-release WAR on GitHub
  3. Copy this PRs cloud-config into DO.
  4. Edit the config so aggregate-cli gets pre-releases (add -ip)
  5. Confirm that cloud-init-output is clean
  6. Run certbot to get HTTPS working
  7. Confirm if page loads with no redirects

Do we need any specific form for testing your changes? If so, please attach one

No.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

ggalmazor commented 5 years ago

I think you're getting the redirects because you haven't refreshed your security.properties and odk-settings.xml files with the new example files that include the new conf params before building the WAR file.

I'm double checking it anyway.