search

getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨
https://docs.opendatakit.org/aggregate-intro/
Other
74 stars 228 forks source link

Issue 409 remove Location header from 204 HTTP responses #417

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

Closes #409

What has been done to verify that this works as intended?

Verify in Aggregate:

Verify using Briefcase:

Why is this the best possible solution? Were any other approaches considered?

HTTP 204 responses should not have a Location header.

Are there any risks to merging this code? If so, what are they?

Nope.

Do we need any specific form for testing your changes? If so, please attach one

No.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

No.

kkrawczyk123 commented 5 years ago

Tested with success! I've checked points mentioned in the pr, I haven't noticed anything suspicious.

@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"