Revert to previous code that had the webapp's path into account - Githubissues

getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨

https://docs.opendatakit.org/aggregate-intro/

Other

74 stars 227 forks source link

Revert to previous code that had the webapp's path into account #421

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

Closes #419

What has been done to verify that this works as intended?

Run Aggregate in a local Tomcat both as ROOT and non-ROOT webapp, having configured a hostname and disabled the hostnames check.

In master, the login of the non-ROOT webapp won't work, and this PR solves that.

Also tested that this PR doesn't break the Cloud-Config stack by running it locally and verifying that the login still works.

Why is this the best possible solution? Were any other approaches considered?

This PR solves a regression bug introduced in v2.0.0. The change is to restore the original redirection code.

Are there any risks to merging this code? If so, what are they?

Nope.

Do we need any specific form for testing your changes? If so, please attach one

No.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

No.

kkrawczyk123 commented 5 years ago

Tested with success!! @opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"