search

getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨
https://docs.opendatakit.org/aggregate-intro/
Other
74 stars 228 forks source link

Upgrade from 1.7.1 to 2.0.0 fails. #429

Closed mathieubossaert closed 5 years ago

mathieubossaert commented 5 years ago

Software and hardware versions

Linux (Docker), Aggregate v1.7.1 over tomcat:alpine (8.5.38-jre8), postgresql 10.7

Problem description

I upgrade from 1.5.0 to 1.6.1 to 1.7.0 to 1.7.1 without a problem but I can't upgrade to 2.0

Steps to reproduce the problem

Expected behavior

Other information

logs mention that problem : "Could not resolve placeholder 'jdbc.driverClassName' in string value "${jdbc.driverClassName}""

Thank's a lot.

yanokwa commented 5 years ago

https://forum.opendatakit.org/t/odk-aggregate-v2-00-possible-bug-in-generated-war-file/18199 looks like the same problem.

ggalmazor commented 5 years ago

Hi, @mathieubossaert!

If I'm not mistaken, you're compiling Aggregate yourself. If so, notice that we've improved the way we handle conf files to avoid pushing modified conf files (with changes for a particular dev's environment). Now, you there's no default conf files in the repo and you can use some .example files at src/main/resources as a template.

The example files should work if your setup is exactly the same as the described in the README's instructions.

Please, let me know if this is what was giving you trouble.

mathieubossaert commented 5 years ago

Hi @ggalmazor,

no I am using the installer. Java lessons are too far from me, but one day, I promise, I will compile Aggregate from sources ;-)

Thanks.

ggalmazor commented 5 years ago

Thanks, @mathieubossaert!

In the meantime, I was checking the installer and I think I've found what's causing the problem. I think we will have to replace the installer for the v2.0 release. The code is OK, but apparently, there are some missing adaptations in the installer from v1.x to v2.0

ggalmazor commented 5 years ago

Hi, @mathieubossaert!

PR #432 fixes the issue with the installer. While we review it, test it, and release it, would you be up for beta testing the installer if I attach here one built by me? If so, which operating system are you running?

mathieubossaert commented 5 years ago

of course I can. I run aggregate into a tomcat:alpine docker container.

ggalmazor commented 5 years ago

~OK, then I need to check more stuff. I'll get back to you about this :)~

Nevermind! Here are the links :)

mathieubossaert commented 5 years ago

"v2.0.0 - You're up to date!"

Thanks a lot Gulliermo !

ggalmazor commented 5 years ago

Awesome! Thanks for testing it ;)

ggalmazor commented 5 years ago

Closed by #422