getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨

https://docs.opendatakit.org/aggregate-intro/

Other

74 stars 227 forks source link

Validate JSON publisher url #436

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

416 introduces validation on the publisher creation forms.

The JSON publisher form only checks that the user enters something in the url field. We should also verify that it's a valid URL string.

kkrawczyk123 commented 5 years ago

I am a fan of the idea of adding validation for valid URL. My other suggestion is to leave the content of that filed empty as default, means remove the current "http://localhost" content. The user can click Publish button just with the default content, adding validation will solve that for sure. But still, publishing servers do not have to be a local one in all cases. What are your opinions on that @ggalmazor and @yanokwa :)

shashvat-kedia commented 5 years ago

@ggalmazor Can I work on this?

ggalmazor commented 5 years ago

Sure, @sd1998!

Let me sum up what has to be done to the JSON Server publisher dialog:

Add validation to the URL field
Remove the default value "http://localhost"

You can claim the issue writing a comment with "@opendatakitbot claim"