search

getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨
https://docs.opendatakit.org/aggregate-intro/
Other
74 stars 228 forks source link

Issue 440 Fix change password url generation #441

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

Closes #440

What has been done to verify that this works as intended?

Launches as non-ROOT webapp in a local tomcat server and changed the password while inspecting the network tab using Chrome's developer console.

Why is this the best possible solution? Were any other approaches considered?

This fixes the issue like in https://github.com/opendatakit/aggregate/commit/048410e8ba18900e642d18db6aa60acf9fa184e2

Are there any risks to merging this code? If so, what are they?

Nope.

Do we need any specific form for testing your changes? If so, please attach one

No.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

No.

zwets commented 5 years ago

I just tested this by replacing only the SecurityServiceImpl.class in my deployed war and can confirm the issue is solved here.

kkrawczyk123 commented 5 years ago

I've tested changing superuser and user passwords, everything worked great for me! @opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"