Update AppEngine uploader app jar

getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨

https://docs.opendatakit.org/aggregate-intro/

Other

74 stars 228 forks source link

Update AppEngine uploader app jar #444

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

This PR updates the AppEngine Uploaded app JAR that the installer uses to deploy Aggregate to AppEngine.

The new uploader includes https://github.com/opendatakit/aggregate-components/pull/5 to avoid problems due to the deprecation of the AppEngine Backends API by Google.

yanokwa commented 5 years ago

This PR itself is fine, but how were the changes in opendatakit/aggregate-components#5 verified? Specifically, can you confirm that

The current installer doesn't work (as described at https://forum.opendatakit.org/t/18605) on a new GAE project.
This installer does work on that project.

ggalmazor commented 5 years ago

Sure!

I've verified that the official v1.7.1 won't complete the upload to AppEngine (complaining about the backends api)
I've verified that the new uploader works :)

I had to replace (again) the uploader jar. The PR is fine as far as I know :)

yanokwa commented 5 years ago

LGTM.

yanokwa commented 5 years ago

@ggalmazor How do you want to handle testing this?

kkrawczyk123 commented 5 years ago

I've checked: install generating, running and GAE installing process without any problems on Ubuntu.

@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"

ggalmazor commented 5 years ago

Thanks! I think we can do a pint release v1.7.2 :)

yanokwa commented 5 years ago

Point release or pint release? 🍺