search

getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨
https://docs.opendatakit.org/aggregate-intro/
Other
74 stars 228 forks source link

URL validation added #451

Closed shashvat-kedia closed 5 years ago

shashvat-kedia commented 5 years ago

Closes #436

What has been done to verify that this works as intended?

Tested the regular expression across multiple URLs.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

No

shashvat-kedia commented 5 years ago

@ggalmazor I have fixed the issue.

shashvat-kedia commented 5 years ago

@ggalmazor I have made the changes. Here are the screenshots of the test I have performed:- image image

ggalmazor commented 5 years ago

The extra urls I've tried are:

kkrawczyk123 commented 5 years ago

I’ve checked empty value, trailing spaces, extra characters, and valid urls too. I have noticed that I am able to use “http://localhost” without adding the port number or even urls like “https://bla” which are not exactly valid ones (like on attached screenshot) Screenshot from 2019-04-09 13-13-32

@opendatakit-bot unlabel "needs testing"

ggalmazor commented 5 years ago

Thanks, @kkrawczyk123! I think we can ignore the fact that http://bla gets through. We should be more concerned about valid urls not passing the validation, and I haven't found a case of that yet.