getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨
https://docs.opendatakit.org/aggregate-intro/
Other
74 stars 228 forks source link

Issue 452 The installer is not configuring the hostname correctly #456

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

Closes #452

Ensure that the installer sets the hostname in output conf files

Screenshot of the Apache Tomcat Port Configuration screen when no SSL is selected: issue 451 screenshot 2

Screenshot of the Apache Tomcat Port Configuration screen when SSL is selected: issue 452 screenshot 1

What has been done to verify that this works as intended?

Build the installer, run it and verify that the output security.properties is correctly configured with whatever value is set in the Internet-visible IP address or DNS name field

Why is this the best possible solution? Were any other approaches considered?

This fixes a bug introduced when removing GAE support from the current master branch

Are there any risks to merging this code? If so, what are they?

None.

Do we need any specific form for testing your changes? If so, please attach one

No.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

No.

kkrawczyk123 commented 5 years ago

Tested with success!

@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"