Aggregate should not block page loads when network is down - Githubissues

getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨

https://docs.opendatakit.org/aggregate-intro/

Other

74 stars 228 forks source link

Aggregate should not block page loads when network is down #459

Closed yanokwa closed 5 years ago

yanokwa commented 5 years ago

Software and hardware versions

Aggregate v2.0.2

Problem description

If you run Aggregate with the network down, the front page does not load. The two network calls that I can see are

For maps.googleapis.com/maps/api/js in AggregateHTMLServlet.java
For api.github.com in LayoutUtils.java

Potential solutions

Add async and defer to Google maps call as shown in the docs at https://developers.google.com/maps/documentation/javascript/tutorial
If the XMLHttpRequest call fails, return a versionNote of "Version check failed" rather than blocking the UI.

ggalmazor commented 5 years ago

Thanks for the research. That will make the fix much easier for me :)