getodk / aggregate

ODK Aggregate is a Java server that stores, analyzes, and presents survey data collected using ODK Collect. Contribute and make the world a better place! ✨🗄✨
https://docs.opendatakit.org/aggregate-intro/
Other
74 stars 228 forks source link

Enable tests on MySQL CI image #465

Closed yanokwa closed 5 years ago

yanokwa commented 5 years ago

Closes #464

What has been done to verify that this works as intended?

Ran it on my CircleCI account branch and ensured the tests ran. I was able to verify that the artifacts showed up in the CI UI.

Why is this the best possible solution? Were any other approaches considered?

It was the fastest way to get it working. I bet we could reduce the duplication and maybe use one container, but I'll leave that as an exercise for the next person.

Are there any risks to merging this code? If so, what are they?

I've reverted back to Postgres 9.4 and combined the config so maybe that will cause a problem.