fixes #217 - Githubissues

sadiqkhoja commented 4 years ago

Closes #217

What has been done to verify that this works as intended?

Added unit tests. Performed manual testing as well:

Without filter:

With 'hide' filter:

Why is this the best possible solution? Were any other approaches considered?

HashMap for 'Hide' visibility was already there, it was just not being used.

Are there any risks to merging this code? If so, what are they?

No.

Do we need any specific form for testing your changes? If so, please attach one

No

Does this change require updates to documentation? If so, please file an issue at https://github.com/getodk/docs/issues/new and include the link below.

No

sadiqkhoja commented 3 years ago

@getodk/aggregate can anyone review this. thanks

sadiqkhoja commented 3 years ago

@getodk-bot @yanokwa can you please review this

lognaturel commented 3 years ago

@sadiqkhoja Thanks for your contribution! The core ODK team is currently very busy and we don't have an Aggregate release upcoming. We will try to plan an Aggregate release and include your fix as soon as we can.

lognaturel commented 3 years ago

Thanks again for this and I do apologize for the long silence.

getodk / aggregate

fixes #217 #495

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

Are there any risks to merging this code? If so, what are they?

Do we need any specific form for testing your changes? If so, please attach one

Does this change require updates to documentation? If so, please file an issue at https://github.com/getodk/docs/issues/new and include the link below.