search

getodk / briefcase

ODK Briefcase is a Java application for fetching and pushing forms and their contents. It helps make billions of data points from ODK portable. Contribute and make the world a better place! ✨💼✨
https://docs.getodk.org/briefcase-intro
Other
60 stars 156 forks source link

Rethink pull_aggregate short form #256

Closed lognaturel closed 6 years ago

lognaturel commented 6 years ago

It's currently -pa but we'll eventually want to be able to push to Aggregate from CLI as well. How do we differentiate between the two since they both start with p?

jpknox commented 6 years ago

Maybe -psha for push and -plla for pull?

lognaturel commented 6 years ago

Good suggestions, @jpknox. The existing "short forms" aren't that short so those would fit in.

@ggalmazor @yanokwa?

ggalmazor commented 6 years ago

Just realized that we could also make a compound command with -pull -a and -push -a.

-a would server to indicate that we want to make an operation against an Aggregate server. It could also be -agg, etc.Then we could have other -odk or -sd flag to tell Briefcase to go to an sd card folder, etc.

yanokwa commented 6 years ago

I think we can keep -pa for backwards compatibility (but warn about deprecation) and introduce -psha and -plla when we add push from the CLI. It doesn't really make sense for Briefcase to push to an SD card for Collect, but pshc would work nicely there.

We need to do a refactor of pull first, then push, then we can add CLI support. Does that plan sound reasonable, @ggalmazor? Do you want to keep this issue open until then or should we close it?

ggalmazor commented 6 years ago

OK, sounds good.

If you want these changes on different PRs, we can add a checklist on the main comment to track progress.

yanokwa commented 6 years ago

I'm closing in favor of https://github.com/opendatakit/briefcase/issues/20. We can track our progress bringing the CLI in line with the GUI there.