getodk / briefcase

ODK Briefcase is a Java application for fetching and pushing forms and their contents. It helps make billions of data points from ODK portable. Contribute and make the world a better place! ✨💼✨
https://docs.getodk.org/briefcase-intro
Other
59 stars 153 forks source link

Remember password turn on/turn off improvement. #536

Open kkrawczyk123 opened 6 years ago

kkrawczyk123 commented 6 years ago

Software versions

Briefcase v1.11.x, Java v1.8.171, operating system: Ubuntu, MacOS and Windows

Problem description

Turning off the Remember passwords works always no matter if you choose it before logging in or after that. Turning on Remember password options works only when it’s set before logging in. I think it would be good to unify that behavior because if you log first and then set Remember passwords option it won’t work even if the checkbox will be set. So I think that it is possible that user encounter situation like that: log in, check Remember Password and expect that connection will be saved - but it is not. It might be confusing as checkbox has been chosen.

kkrawczyk123 commented 6 years ago

@opendatakit-bot label "needs discussion"

ggalmazor commented 6 years ago

Yeah, that can be confusing... Did you have a solution in mind?

Maybe the simplest thing I can think of is to pop a dialog telling him that passwords will start to be remembered from that moment on.

kkrawczyk123 commented 6 years ago

There are not many options on Setting tab, so we could add information below the checkbox, something similar that we have with "Pull before export" and "Requires Remember password in Settings"/"Requires manually pulling from Aggregate once".

ggalmazor commented 6 years ago

I think this one is a good candidate for a "good first issue" tag if we can agree on the feedback we want to give to users. Want to pitch in, @yanokwa, @lognaturel?