search

getodk / briefcase

ODK Briefcase is a Java application for fetching and pushing forms and their contents. It helps make billions of data points from ODK portable. Contribute and make the world a better place! ✨💼✨
https://docs.getodk.org/briefcase-intro
Other
59 stars 153 forks source link

Issue #761 Encoding issues when pulling submissions with Arabic characters in Windows #762

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

Closes #761

What has been done to verify that this works as intended?

Manually tested on a Windows 10 machine using the form attached to the issue Manually tested on Linux to ensure that it still worked as expected on another system.

Why is this the best possible solution? Were any other approaches considered?

This is a narrow fix and I didn't consider any other approach.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It feels like it's a safe change with no risk of affecting in an unpredictable manner.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

Nope.

kkrawczyk123 commented 5 years ago

Tested with success!! Verified on Ubuntu, MacOS and Windows.

@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"