search

getodk / briefcase

ODK Briefcase is a Java application for fetching and pushing forms and their contents. It helps make billions of data points from ODK portable. Contribute and make the world a better place! ✨💼✨
https://docs.getodk.org/briefcase-intro
Other
59 stars 153 forks source link

Issue 777 Latest Central rejects multiple simultaneous auth methods #778

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

Closes #777

What has been done to verify that this works as intended?

Manually test against bleeding edge Central server at antinod.es

Why is this the best possible solution? Were any other approaches considered?

Central (latest) will reject requests arriving with auth tokens and session cookies. Since we don't really need cookies for anything, this is a quick fix for this issue while we decide what to do about auth in Central

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

There's the risk of undocumented dependency on cookies by aggregate-compatible servers that we don't know about. If any of these servers rely upon cookies that were being sent, pull/push operations could fail due to this change. Testing in known servers (Ona, Kobo...) would be required to ensure we're breaking anything.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

Nope.

kkrawczyk123 commented 5 years ago

Tested with success! Verified on Ubuntu, MacOS and Windows.

@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"

ggalmazor commented 5 years ago

Hi, @dcbriccetti! Will you have some cycles this week to do this one? We would like to release v1.17 next week if possible ;)