Issue #791 Match case when finding xml element - Githubissues

getodk / briefcase

ODK Briefcase is a Java application for fetching and pushing forms and their contents. It helps make billions of data points from ODK portable. Contribute and make the world a better place! ✨💼✨

https://docs.getodk.org/briefcase-intro

Other

60 stars 154 forks source link

Issue #791 Match case when finding xml element #792

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

Closes #791

What has been done to verify that this works as intended?

Added automated regression test Manually exported the form attached to the issue

Test this PR with briefcase_pr_792.zip

Why is this the best possible solution? Were any other approaches considered?

Super narrow fix to avoid confusing field mappers when two fields have the same name with case differences.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This shouldn't change any other behavior.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

Nope.

aurdipas commented 5 years ago

tested successfully with the form that was generating the error. Thanks also for this +1

kkrawczyk123 commented 5 years ago

Tested with success!! Verified on Ubuntu, MacOS and Windows.

@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"