search

getodk / briefcase

ODK Briefcase is a Java application for fetching and pushing forms and their contents. It helps make billions of data points from ODK portable. Contribute and make the world a better place! ✨💼✨
https://docs.getodk.org/briefcase-intro
Other
60 stars 154 forks source link

Issue #799 Fix getting form name for form keys #803

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

Closes #799

What has been done to verify that this works as intended?

Added an automated regression test

Why is this the best possible solution? Were any other approaches considered?

This is not an optimal solution because it involves reparsing form definitions to get their names, but changing the underlying JavaRosaParserWrapper is much riskier because more code depends on that.

Also, this change will become irrelevant once we have v2.0, so it feels like we wont' be running into much problems anyway.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

There should be no changes in behavior due to this change.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

Nope.

kkrawczyk123 commented 5 years ago

Tested with success! Verified on Ubuntu, MacOS and Windows.

@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"

dcbriccetti commented 5 years ago

Looking now