getodk / briefcase

ODK Briefcase is a Java application for fetching and pushing forms and their contents. It helps make billions of data points from ODK portable. Contribute and make the world a better place! ✨💼✨
https://docs.getodk.org/briefcase-intro
Other
60 stars 154 forks source link

Issue #806 Metadata files should have relative paths #807

Closed ggalmazor closed 5 years ago

ggalmazor commented 5 years ago

Closes #806

What has been done to verify that this works as intended?

Fixed and run the automated tests Manually pulled forms, changed the sd location, and exported them

Why is this the best possible solution? Were any other approaches considered?

This is the smallest change I could come up to be able to store relative paths while providing absolute paths to downstream code.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No risks here, just a fixed bug :)

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

Nope.

kkrawczyk123 commented 5 years ago

Tested with success! Verified on Ubuntu, MacOS and Windows.

@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"