search

getodk / briefcase

ODK Briefcase is a Java application for fetching and pushing forms and their contents. It helps make billions of data points from ODK portable. Contribute and make the world a better place! ✨💼✨
https://docs.getodk.org/briefcase-intro
Other
60 stars 154 forks source link

fix: added toString for CentralErrorMessage #822

Closed florian42 closed 4 years ago

florian42 commented 4 years ago

Closes: #821

All tests were executed succesfully.

codecov-io commented 4 years ago

Codecov Report

Merging #822 into master will decrease coverage by <.01%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #822      +/-   ##
============================================
- Coverage     48.63%   48.63%   -0.01%     
+ Complexity     1643     1642       -1     
============================================
  Files           192      192              
  Lines         10319    10320       +1     
  Branches        743      743              
============================================
  Hits           5019     5019              
- Misses         4942     4943       +1     
  Partials        358      358
Impacted Files Coverage Δ Complexity Δ
...it/briefcase/push/central/CentralErrorMessage.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...g/opendatakit/briefcase/ui/export/ExportPanel.java 48.07% <0%> (ø) 14% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7cc413...083d9fe. Read the comment docs.

ggalmazor commented 4 years ago

So, some tips for testing this copied from the issue:

kkrawczyk123 commented 4 years ago

Finally tested with success! Verified on Ubuntu, MacOS and Windows.

@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"

ggalmazor commented 4 years ago

Thank you for your patience, @kkrawczyk123 ;)