getodk / briefcase

ODK Briefcase is a Java application for fetching and pushing forms and their contents. It helps make billions of data points from ODK portable. Contribute and make the world a better place! ✨💼✨

https://docs.getodk.org/briefcase-intro

Other

60 stars 154 forks source link

Reduce indirection and loose coupling with UI colors #838

Closed ggalmazor closed 4 years ago

ggalmazor commented 4 years ago

830 introduces new UI table sorting methods that are loosely coupled with the colors we're using to represent active/inactive buttons. The methods also introduce indirection between "something having X color" and "that something having Y business meaning".

We should extract all related business concepts into some artifact that can be reused in both placed. For example, a ExportConfigurationButton class, could have methods such as isSelected(JButton button), or sort(JButton o1, JButton o2) among other. The goal would be to have all the business needs related to export conf buttons in a single place that can be used everywhere.

jay4kelly commented 4 years ago

@opendatakit-bot claim

ggalmazor commented 4 years ago

Hi, @jay4kelly! Thanks for claiming this one. Since the solution will affect the design, we can discuss your ideas over in Slack if you want. I'll be around in the #briefcase-code channel.

getodk-bot commented 4 years ago

Hello @jay4kelly, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 15 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

jay4kelly commented 4 years ago

I've implemented the export configuration button. I'm now working on the detail configuration button.