Closed ggalmazor closed 4 years ago
Tested with success! I have checked if forms pulled on Windows have in metadata file / dir separators as in other systems. I have also checked if the content of sd created on Windows is useable on Ubuntu and Mac. I have checked if sd created on Ubuntu and MacOS are also useable on Windows. I was testing on Windows 10.
@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"
Closes #844
What has been done to verify that this works as intended?
Two things:
Manually pulled some forms in a Windows 10 box and verified that the paths in the
metadata.json
files contain/
dir separators (instead of the standard\
for Windows)Also verified that Briefcase can read these paths and work in Windows 10 too.
Added new automated tests to verify we will never include
/
, or\
in form directory names.\
would be valid in *nix filenames, but then we would have portability issues in Windows.Why is this the best possible solution? Were any other approaches considered?
This PR felt like it fell kinda short in two ways:
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The most risky assumption is that, according to official Java docs,
/
dir separators should work both in Windows and *nix platforms. Other than that, changes in this PR feel pretty much safe.Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.
Nope.