search

getodk / briefcase

ODK Briefcase is a Java application for fetching and pushing forms and their contents. It helps make billions of data points from ODK portable. Contribute and make the world a better place! ✨💼✨
https://docs.getodk.org/briefcase-intro
Other
60 stars 154 forks source link

A solution for Bug #798 #851

Closed gilbva closed 4 years ago

gilbva commented 4 years ago

The bug was caused by the fact that the Source/Target panel has no information that the forms are being loaded from the server. Making a call to setWorking() in the current view makes the buttons in the Source/Target panel to go disabled until the unsetWorking method is call. I think this fixes the bug as the user won be able to click on reset (or reload) during the time the forms are being loaded, and also the user will have good feedback.

Closes #

What has been done to verify that this works as intended?

I was able to reproduce the bug before the fix, after the fix i cannot hit the reset button while loading.

Why is this the best possible solution? Were any other approaches considered?

It uses the already created method setWorking that is intended for this kind of behavior

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The user won be able to cancel the form loading process, but i think that is ok.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

I dont think this need to be put explicitly in the documentation as is a minor fix.

codecov-io commented 4 years ago

Codecov Report

Merging #851 into master will decrease coverage by 0.01%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #851      +/-   ##
============================================
- Coverage     48.29%   48.28%   -0.02%     
  Complexity     1641     1641              
============================================
  Files           195      195              
  Lines         10384    10387       +3     
  Branches        750      750              
============================================
  Hits           5015     5015              
- Misses         5012     5015       +3     
  Partials        357      357
Impacted Files Coverage Δ Complexity Δ
...c/org/opendatakit/briefcase/ui/pull/PullPanel.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37c0847...9c06ecd. Read the comment docs.

kkrawczyk123 commented 4 years ago

Tested with success! I was not able to reproduce steps from the issue. I have also performed some exploratory testing of changing servers, url connections, between pull and push tab. Verified on Ubuntu, MacOS and Windows.

@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"