search

getodk / briefcase

ODK Briefcase is a Java application for fetching and pushing forms and their contents. It helps make billions of data points from ODK portable. Contribute and make the world a better place! ✨💼✨
https://docs.getodk.org/briefcase-intro
Other
60 stars 156 forks source link

bugFix to be able to push form to aggregate #855

Closed yougis closed 4 years ago

yougis commented 4 years ago

Closes #854

What has been done to verify that this works as intended?

run on debug, build, create jar File

Why is this the best possible solution? Were any other approaches considered?

this is a quick hot fix

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

nothing worst.

Does this change require updates to documentation? If so, please file an issue at https://github.com/opendatakit/docs/issues/new and include the link below.

nope

ggalmazor commented 4 years ago

Hi, @yougis!

Thanks for documenting this issue! You even tracked down the log in Aggregate! :O

I think that the change you're suggesting works, but I also suspect that the whole line from CommonsHttp could be removed, as the TODO comment suggests. Could you try that, please?

ggalmazor commented 4 years ago

Hi again! It turns out I was wrong and there are some cases where everything relies on the CommonHttp class adding the header, so the PR is perfect as it is, pending further investigation. Ideally, each request would add all the required headers. The CommonsHttp class shouldn't know any specifics about OpenRosa.

yougis commented 4 years ago

greate ! I am happy to get my (little) contribution merged !

kkrawczyk123 commented 4 years ago

Verified with success! Verified on Ubuntu.

Tested scenarios:

@opendatakit-bot unlabel "needs testing" @opendatakit-bot label "behavior verified"