getodk / briefcase

ODK Briefcase is a Java application for fetching and pushing forms and their contents. It helps make billions of data points from ODK portable. Contribute and make the world a better place! ✨💼✨
https://docs.getodk.org/briefcase-intro
Other
60 stars 156 forks source link

Pull from Collect directory where a few versions of the same form are available is not possible #883

Open mmarciniak90 opened 3 years ago

mmarciniak90 commented 3 years ago

Software versions

Briefcase v1.17.4 (only this version was checked)

Problem description

Pull from Collect directory where a few versions of the same form are available is not possible

Steps to reproduce the problem

  1. User selects Collect directory on Pull tab
  2. User adds directory with a few versions of the same form odk.zip or from this, it is cleared odk.zip
  3. User sees unexpected behavior
    • Pull button is inactive when all forms are selected
    • Select All button display instead of Clear All even if all forms are selected
    • If only 2 versions of form are selected and Pull button is clicked, the process never ends
Zrzut ekranu 2020-10-20 o 17 44 22 Zrzut ekranu 2020-10-20 o 17 45 13
lognaturel commented 3 years ago

I think our best bet would be to change TransferForms.formsIndex to a Map<String, List<FormStatus>> instead of Map<String, FormStatus>. The workaround is to just pull the most recent form version. Ideally form version would be displayed in the UI.