Closed lognaturel closed 3 years ago
Merging #885 into master will decrease coverage by
0.04%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #885 +/- ##
============================================
- Coverage 48.33% 48.28% -0.05%
+ Complexity 1647 1645 -2
============================================
Files 195 195
Lines 10422 10423 +1
Branches 753 753
============================================
- Hits 5037 5033 -4
- Misses 5026 5029 +3
- Partials 359 361 +2
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...takit/briefcase/reused/transfer/CentralServer.java | 81.81% <0.00%> (-0.50%) |
38.00 <1.00> (+1.00) |
:arrow_down: |
...g/opendatakit/briefcase/ui/export/ExportPanel.java | 48.07% <0.00%> (-1.93%) |
14.00% <0.00%> (-1.00%) |
|
...g/opendatakit/briefcase/reused/UncheckedFiles.java | 44.53% <0.00%> (-1.69%) |
31.00% <0.00%> (-1.00%) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b55a171...663627f. Read the comment docs.
Tested with success! Verified on Ubuntu.
Tested cases:
@getodk-bot unlabel "needs testing" @getodk-bot label "behavior verified"
Closes #861
What has been done to verify that this works as intended?
Added a draft form definition to Central project, configured that project as a pull source, verified that the draft form didn't show up in the list.
Why is this the best possible solution? Were any other approaches considered?
This filters out drafts which is exactly what we want. I don't see any other possibilities.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It should just fix the bug. It's a one line change that's very targeted so should truly be very low risk.
Does this change require updates to documentation? If so, please file an issue at https://github.com/getodk/docs/issues/new and include the link below.
No.