getodk / briefcase

ODK Briefcase is a Java application for fetching and pushing forms and their contents. It helps make billions of data points from ODK portable. Contribute and make the world a better place! ✨💼✨
https://docs.getodk.org/briefcase-intro
Other
60 stars 156 forks source link

Make documentation link in Central push warning dialog clickable #890

Open lognaturel opened 3 years ago

lognaturel commented 3 years ago

Software versions

master (post https://github.com/getodk/briefcase/pull/872)

Problem description

https://github.com/getodk/briefcase/pull/872 introduced a new warning dialog with a documentation reference when pushing a form with multiple versions to Central. Currently the documentation reference is just plain text. Ideally it would be clickable.

Screen Shot 2020-10-30 at 11 15 20 AM

Steps to reproduce the problem

  1. Pull a form with submissions from multiple different versions. To simulate this, you could put versioned.zip in the forms folder of your Briefcase directory
  2. Configure a Central server
  3. Initiate a push of the versioned form
  4. See the confirmation dialog

Expected behavior

Clickable link

https://github.com/getodk/briefcase/pull/872/files#diff-81f1259745a11e2b9ff53e749c1322de33b8738f808d457ad78b6d42c85d0fafR101 is where the dialog is launched.