search

getodk / briefcase

ODK Briefcase is a Java application for fetching and pushing forms and their contents. It helps make billions of data points from ODK portable. Contribute and make the world a better place! ✨💼✨
https://docs.getodk.org/briefcase-intro
Other
60 stars 156 forks source link

Small fix to remove the csv qualifier and \n from text before generating csv file. #896

Closed anaskhl closed 3 years ago

anaskhl commented 3 years ago

Closes #

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to documentation? If so, please file an issue at https://github.com/getodk/docs/issues/new and include the link below.

lognaturel commented 3 years ago

Thanks for your interest in Briefcase! As you can see, this change breaks behavior that we have explicit tests for. If you're having a problem with an export CSV, please start with describing that issue at https://forum.getodk.org/c/support/6 so we can discuss what possible actions to take would be.

anaskhl commented 3 years ago

Thanks, Helene, I realized that. The problem for me is the repeated NewLine values in string, causing my CSV columns values to shift. When I parse it with SSIS. I wanted to perform the fix, I generated the jar file, and it worked for me, but when I pushed the code, I realized you have the tests implemented for this. I am new to the briefcase, I tried to follow the instructions, but I missed some. My apologies.