search

getodk / build2xlsform

service to convert odkbuild-form json to xlsform-compliant xlsx.
Other
2 stars 8 forks source link

new: Dockerfile and GHA #23

Closed florianm closed 2 years ago

florianm commented 2 years ago

This PR brings a Dockerfile and a GH action to build and push the image to ghcr.io. The action requires two secrets:

echo "${{ secrets.GH_PAT }}" | docker login ghcr.io -u ${{ secrets.GH_ACTOR }} --password-stdin

GH_PAT and GH_ACTOR. It works nicely with my own GH username as actor (florianm) and my PAT. The image https://github.com/orgs/florianm/packages/container/package/odkbuild2xlsform is used and works with https://github.com/getodk/build/pull/283.

There is one change to make before merging, deletion of the "branches" key (so I can trigger builds during dev) to only build and push the Docker image when a new Git tag is pushed. I have made this change after an initial image was built to use in https://github.com/getodk/build/pull/283, and now dropped the "branches" key.

I expect that this PR will work once the getodk/build2xlsform repo has the two secrets defined. The only way to find out for sure is to merge. I see low risk in a merge, as it doesn't impact the source install at all.

Fixes #21

florianm commented 2 years ago

@lognaturel I think this one is ready for a final review, I might have gotten the grammar right now