Fixes some CSS issues that came from supporting a longer app user name and caused weird padding to appear behind the app user QR popover.
Looks better now!
Looks ok here, too.
What has been done to verify that this works as intended?
visually inspecting it.
Why is this the best possible solution? Were any other approaches considered?
The element for saying the new app user/QR code was successfully created is now a sibling of the element with the actual QR code in it, instead of the parent. Changed the CSS a bit to support the QR code element being shown in two places a) the success modal, and b) the normal re-viewing of a QR code in the popover.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Fixes a bug.
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
[ ] run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
[ ] verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced
Closes https://github.com/getodk/central/issues/663
Fixes some CSS issues that came from supporting a longer app user name and caused weird padding to appear behind the app user QR popover.
Looks better now!
Looks ok here, too.
What has been done to verify that this works as intended?
visually inspecting it.
Why is this the best possible solution? Were any other approaches considered?
The element for saying the new app user/QR code was successfully created is now a sibling of the element with the actual QR code in it, instead of the parent. Changed the CSS a bit to support the QR code element being shown in two places a) the success modal, and b) the normal re-viewing of a QR code in the popover.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Fixes a bug.
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes