As part of #1004, I added a new property to testData.extendedForms (publicLinks). I randomly noticed that testData.extendedForms has the property lastEntity, but I don't think that Backend actually returns that property. This PR removes lastEntity from testData.extendedForms. It also makes a few other changes related to lastEntity, mostly making it more consistent with other testData properties. See the commit message for details.
What has been done to verify that this works as intended?
Tests continue to pass.
Why is this the best possible solution? Were any other approaches considered?
I think it's good to try to make testData as similar to Backend as possible. Where it's easy to do, I also think it's nice to try to make testData internally consistent.
Before submitting this PR, please make sure you have:
[x] run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
[x] verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced
As part of #1004, I added a new property to
testData.extendedForms(publicLinks). I randomly noticed thattestData.extendedFormshas the propertylastEntity, but I don't think that Backend actually returns that property. This PR removeslastEntityfromtestData.extendedForms. It also makes a few other changes related tolastEntity, mostly making it more consistent with othertestDataproperties. See the commit message for details.What has been done to verify that this works as intended?
Tests continue to pass.
Why is this the best possible solution? Were any other approaches considered?
I think it's good to try to make
testDataas similar to Backend as possible. Where it's easy to do, I also think it's nice to try to maketestDatainternally consistent.Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes