getodk / central-frontend

Vue.js based frontend for ODK Central
https://docs.getodk.org/central-intro/
Apache License 2.0
32 stars 56 forks source link

Don't italicize Japanese or Chinese #1008

Closed matthew-white closed 1 month ago

matthew-white commented 1 month ago

For Japanese, we use bold instead of italics for <em> elements. Apparently, italics aren't used in Japanese. That was something I mentioned when I added Japanese in the first place. However, as I'm adding Chinese just now, I'm realizing that there are elements outside <em> where we italicize using CSS. This PR makes a similar change as for <em> elements, making those elements bold instead of italic for Japanese.

In #1006, I made Chinese bold instead of italic, similar to Japanese. I've read that italics also aren't used in Chinese. I'm not sure that bold is the very best option (the article suggests underdots in some cases), but it sounds like it's an improvement over italic. The article makes it clear that multiple options are better than italic. If we receive feedback from the Chinese translator or from users, I'd be happy to do something different.

What has been done to verify that this works as intended?

I spot-checked a few of these changes.

Why is this the best possible solution? Were any other approaches considered?

I added a mixin for this, which I think is the most ergonomic.

Before submitting this PR, please make sure you have:

matthew-white commented 1 month ago

I'll go ahead and add this PR to the project, since it's an existing issue with Japanese.