Upgraded getodk/web-forms to v0.2 which brings in a appearances for Select questions.
Added a CSS fix for the stopping bootstrap messing up with the styles of new web form component. We could have added this fix in the code of web-forms but it was decided that for now it is best to add in Central and update the docs of web-forms to let other host applications to do that same.
What has been done to verify that this works as intended?
Manually tested it to ensure various select appearances are rendered correctly.
Why is this the best possible solution? Were any other approaches considered?
Second commit in this PR reverts all the styling added by bootstrap and other css files for new Web Forms component. The approach felt cleanest to me. Other options were to dynamically removed the <style> tags when rending new Web Forms or when meta.standalone is true - that would also removed styles for dialog box that we show on "Send" button.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
None
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
Not sure we want to update the documentation for this feature or just announce it on the Forum.
Before submitting this PR, please make sure you have:
[x] run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
[x] verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced
getodk/web-formsto v0.2 which brings in a appearances for Select questions.web-formsbut it was decided that for now it is best to add in Central and update the docs ofweb-formsto let other host applications to do that same.What has been done to verify that this works as intended?
Manually tested it to ensure various select appearances are rendered correctly.
Why is this the best possible solution? Were any other approaches considered?
Second commit in this PR reverts all the styling added by bootstrap and other css files for new Web Forms component. The approach felt cleanest to me. Other options were to dynamically removed the
<style>tags when rending new Web Forms or whenmeta.standaloneis true - that would also removed styles for dialog box that we show on "Send" button.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
None
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
Not sure we want to update the documentation for this feature or just announce it on the Forum.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes