Space beneath the form attachment list

getodk / central-frontend

Vue.js based frontend for ODK Central

https://docs.getodk.org/central-intro/

Apache License 2.0

32 stars 58 forks source link

Space beneath the form attachment list #144

Open matthew-white opened 6 years ago

matthew-white commented 6 years ago

There seems to be some blank space beneath the form attachment list where the background of the page is visible:

The space disappears when the viewport is narrow enough:

I know that the modal classes used for the popup have different effects based on the viewport width, which makes me think that the additional space could be related to those classes.

What should be done about this space? Is it fine for it to remain, or should we try to remove it?

matthew-white commented 5 years ago

Kasia and Marzena note that this space is pretty large, so I think we should try to remove it.

matthew-white commented 5 years ago

Interestingly, I see this space in Chrome, but I don't see it in Firefox.

issa-tseng commented 5 years ago

oh it’s on this page. huh yeah i dunno then. we can fix it. On Tue, Nov 13, 2018 at 14:28 Matthew White notifications@github.com wrote:

Interestingly, I see this space in Chrome, but I don't see it in Firefox.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/opendatakit/central-frontend/issues/144#issuecomment-438462649, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHMArP2DLIcoNHVZgybctD0Ra19rIDmks5uu0d8gaJpZM4Wd4K0 .

matthew-white commented 5 years ago

@kkrawczyk123 notes:

Confirmed that it is not visible on Firefox and Safari. It is visible on Chrome and Egde.