What has been done to verify that this works as intended?
Trying it out and adding tests.
Why is this the best possible solution? Were any other approaches considered?
I don't think this is the best -- this component is complicated and confusing.
It can handle entity events.
It can also handle artificial events for submission creation/approval when that is relevant to an entity...
It can handle events about entities that contain submission info in the details.
The submissions in the two cases above can be available or deleted, and can show the instance name or instance id depending.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Getting some warnings running the full test suite:
WARN LOG: '[Vue warn]: Unhandled error during execution of render function', '
', ' at <PageSection', 'id="entity-activity"', '>', '
', ' at <EntityActivity>', '
', ' at <PageBody>', '
', ' at <EntityShow', 'projectId="1"', 'datasetName="trees"', 'uuid="e"', ' ...', '>', '
', ' at <VTUROOT>'
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
[ ] run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
[ ] verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced
Closes #
What has been done to verify that this works as intended?
Trying it out and adding tests.
Why is this the best possible solution? Were any other approaches considered?
I don't think this is the best -- this component is complicated and confusing.
It can handle entity events. It can also handle artificial events for submission creation/approval when that is relevant to an entity... It can handle events about entities that contain submission info in the details. The submissions in the two cases above can be available or deleted, and can show the instance name or instance id depending.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Getting some warnings running the full test suite:
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes