search

getodk / central-frontend

Vue.js based frontend for ODK Central
https://docs.getodk.org/central-intro/
Apache License 2.0
32 stars 57 forks source link

Add tests of entity conflict summary table #923

Open matthew-white opened 8 months ago

matthew-white commented 8 months ago

The entity conflict summary table was added in #894. However, that PR included a limited number of tests. This issue is to add more tests of the table. The following comment lists cases to include in those tests: https://github.com/getodk/central/issues/529#issuecomment-1822059754

matthew-white commented 6 months ago

Here's one piece of code that I'm pretty sure isn't working right now:

https://github.com/getodk/central-frontend/blob/00d84096788bbf31bd4ca903449848e8fd177159/src/components/entity/conflict-table.vue#L142-L151

Specifically, dataset.properties is an array of objects, not an array of names, so line 147 should probably be something like:

const propertySet = new Set(dataset.properties.map(({ name }) => name));