getodk / central-frontend

Vue.js based frontend for ODK Central
https://docs.getodk.org/central-intro/
Apache License 2.0
32 stars 57 forks source link

Show custom alert message for 404.1 Problem #952

Closed matthew-white closed 6 months ago

matthew-white commented 6 months ago

@srujner found at getodk/central#591 that with entity deletion in place, there are cases in which a user will see a 404.1 Problem in Frontend. Example: two users are viewing the entities table; the first user deletes an entity; then the second clicks More for the same entity; the second user will see a 404.1 Problem on the entity details page. @srujner and I discussed that it'd be helpful to explicitly mention in the 404.1 Problem the possibility that the resource has been deleted. In this PR, Frontend will show a custom alert message along those lines if it receives a 404.1 Problem. I asked @alyblenkin about the specific text of the message. A nice side effect of this PR is that the message will also be translated.

What has been done to verify that this works as intended?

A new unit test. I also verified locally that the custom message was shown for a 404.1 Problem. I don't think this change needs to be verified by the QA team.

Before submitting this PR, please make sure you have: