getodk / central-frontend

Vue.js based frontend for ODK Central
https://docs.getodk.org/central-intro/
Apache License 2.0
32 stars 57 forks source link

Fix bug where upload progress was not shown in FormAttachmentPopups #954

Closed matthew-white closed 6 months ago

matthew-white commented 6 months ago

Closes getodk/central#606. The issue is that the event passed to the onUploadProgress callback no longer has a lengthComputable property. I've filed an issue about that at axios/axios#6290. However, the event now has a convenient progress property that we can use instead.

What has been done to verify that this works as intended?

It's difficult to write a test for this change for reasons described at https://github.com/getodk/central-frontend/issues/127#issuecomment-1987589289. However, I verified the change locally.

Before submitting this PR, please make sure you have: